Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding-top and padding-bottom is wrongly calculated #15

Open
lubomirblazekcz opened this issue Sep 21, 2020 · 4 comments
Open

padding-top and padding-bottom is wrongly calculated #15

lubomirblazekcz opened this issue Sep 21, 2020 · 4 comments

Comments

@lubomirblazekcz
Copy link

padding-top and padding-bottom is wrongly calculated when element is closed by default with display: none or DOM-slider-hidden

on the first opening the padding-top and padding-bottom is always 0px

@lubomirblazekcz
Copy link
Author

lubomirblazekcz commented Sep 21, 2020

https://jsfiddle.net/tr3v1cky/8/

here is demo, it happens always - seems that box-sizing: border-box is the main problem

solution would be not subtracting the paddings when border-box is set

@BrentonCozby
Copy link
Owner

BrentonCozby commented Sep 21, 2020

@evromalarkey I've published the fix you mentioned and updated the CDN link in the README. Unfortunately, this only seems to fix it after the first call to slideToggle; the transition jumping becomes smooth with every slideToggle after the first one.

I've actually seen this bug before but I'm still unaware of a solution.

@lubomirblazekcz
Copy link
Author

Thanks for the quick fix, I was able to fix it even on the first slide. You have to add paddingTop and paddingBottom when the element is hidden, because before that the padding is always 0, so if you add condition for borderBox here also, it should fix it.

        if (slideDirection === 'down' && isDisplayNoneByDefault) {
            element.classList.add('DOM-slider-hidden');
            element.style.display = visibleDisplayValue;
            contentHeight = Math.max(element.scrollHeight + paddingTop + paddingBottom, 0);
        } // a fixed height is required in order to animate the height

@BrentonCozby
Copy link
Owner

BrentonCozby commented Sep 25, 2020

...You have to add paddingTop and paddingBottom when the element is hidden, because before that the padding is always 0, so if you add condition for borderBox here also, it should fix it.

        if (slideDirection === 'down' && isDisplayNoneByDefault) {
            ...
            contentHeight = Math.max(element.scrollHeight + paddingTop + paddingBottom, 0);
        }

@evromalarkey Unfortunately, this breaks the FAQs in the example.html I provided, causing them to expand too far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants