Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation #355

Merged
merged 3 commits into from Jan 19, 2023
Merged

Add Japanese translation #355

merged 3 commits into from Jan 19, 2023

Conversation

nattyan-tv
Copy link
Contributor

Added Japanese translation to the UI. (Work completed)
README is not translated.

  • Have you run the application to make sure your code runs
  • Is this not just a simple formatting change

Translation checklist

  • Have you run the application to make sure your code runs
  • Have you used the correct keys for your translations added (e.g. en)
  • Have you made sure to leave a , at the end of each translation added
  • Have you added the language to supportedLanguages in alphabetical order
  • Have you added the language to the table in README.md in alphabetical order

brentvollebregt
brentvollebregt requested changes Jan 19, 2023
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Just a few missed commas from what I can see.

auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
@nattyan-tv
Copy link
Contributor Author

I am sorry!
I've just corrected it.

@brentvollebregt brentvollebregt merged commit ddd2fa0 into brentvollebregt:master Jan 19, 2023
@brentvollebregt
Copy link
Owner

Thank you! This will be in the next release - hopefully in a few hours after I make some changes

@brentvollebregt
Copy link
Owner

This has just been released in 2.27.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvollebregt brentvollebregt brentvollebregt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nattyan-tv @brentvollebregt