Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #391

Closed
wants to merge 1 commit into from
Closed

Conversation

7777Hecker
Copy link
Contributor

@7777Hecker 7777Hecker commented Apr 25, 2023

add the new language: Vietnamese

Describe your change

Insert a breif description about what your change is / does.

If this is related to an issue, please link the issue here

New feature checklist

  • Have you run the application to make sure your code runs
  • Is this not just a simple formatting change

Translation checklist

  • Have you run the application to make sure your code runs
  • Have you used the correct keys for your translations added (e.g. en)
  • Have you made sure to leave a , at the end of each translation added
  • Have you added the language to supportedLanguages in alphabetical order
  • Have you added the language to the table in README.md in alphabetical order
  • If you have translated the README, have you linked it in README.md

add the new language: Vietnamese
@brentvollebregt
Copy link
Owner

brentvollebregt commented May 2, 2023

There are no translations in this PR - maybe you forgot to add them?

Nevermind, I now see they are in #390 - could you merge the changes in the two PRs into one of these PRs? (either is fine).

@brentvollebregt
Copy link
Owner

I cherry-picked this PR into #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants