style: highlight code snippets #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you view this on a mobile screen, the content will overflow. It would be good to have the |
brentvollebregt
requested changes
Jul 24, 2020
templates/index.html
Outdated
| @@ -66,7 +68,11 @@ <h1><a href="https://github.com/brentvollebregt/hit-counter">Hit Counter</a></h1 | |||
|
|
|||
| <h2 class="mt-4">Get the Image for the Page It's On</h2> | |||
| <p class="my-1">If you want to get the hit count image for a page you can edit and you want to count, add this line:</p> | |||
| <p id="standard" class="text-primary my-0 o-a"><img src="<script>host()</script>/count/tag.svg" alt="Hits"></p> | |||
| <div> | |||
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> | |||
There was a problem hiding this comment.
Suggested change
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> | |
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-inline-flex align-items-center justify-content-center"> |
templates/index.html
Outdated
| @@ -87,9 +93,17 @@ <h2 class="mt-4">Generate SVG Code For A Different Website</h2> | |||
| <img id="resultImage" src="" alt="Selected Hit Counter"> | |||
| </div> | |||
| <p class="text-muted my-1">Image Tag</p> | |||
| <p id="resultImageTag" class="text-primary my-0 o-a"></p> | |||
| <div> | |||
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> | |||
There was a problem hiding this comment.
Suggested change
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> | |
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-inline-flex align-items-center justify-content-center"> |
templates/index.html
Outdated
| <p class="text-muted my-1">Markdown</p> | ||
| <p id="resultMarkdown" class="text-primary my-0 o-a"></p> | ||
| <div> | ||
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> |
There was a problem hiding this comment.
Suggested change
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-flex align-items-center justify-content-center"> | |
| <pre class="bg-gray-700 mw-100 rounded py-2 px-4 d-inline-flex align-items-center justify-content-center"> |
brentvollebregt
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few minor styling changes that I personally like. In case you don't, feel free to simply close the PR.