Further attempt at capturing reaper error logs

breskeby · Aug 11, 2022 · 65d997d · 65d997d
1 parent 68aa9c4
commit 65d997d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/build-tools-internal/src/main/groovy/elasticsearch.build-complete.gradle b/build-tools-internal/src/main/groovy/elasticsearch.build-complete.gradle
@@ -23,7 +23,7 @@ if (buildNumber) {
         fileset(dir: projectDir) {
           Set<File> fileSet = fileTree(projectDir) {
             include("**/*.hprof")
-            include("**/reaper.log")
+            include("**/build/test-results/**/*.xml")
             include("**/build/testclusters/**")
             exclude("**/build/testclusters/**/data/**")
             exclude("**/build/testclusters/**/distro/**")
@@ -48,6 +48,8 @@ if (buildNumber) {
         }
 
         fileset(dir: "${gradle.gradleUserHomeDir}/workers", followsymlinks: false)
+
+        fileset(dir: "${project.projectDir}/.gradle/reaper", followsymlinks: false)
       }
     } catch (Exception e) {
       logger.lifecycle("Failed to archive additional logs", e)

diff --git a/build-tools/reaper/src/main/java/org/elasticsearch/gradle/reaper/Reaper.java b/build-tools/reaper/src/main/java/org/elasticsearch/gradle/reaper/Reaper.java
@@ -83,17 +83,17 @@ private void reap() {
                     delete(inputFile);
                 }
             }
-        } catch (Exception e) {
+        } catch (Throwable e) {
+            failed = true;
             logFailure("Failed to reap inputs", e);
         }
     }
 
-    private void logFailure(String message, Exception e) {
+    private void logFailure(String message, Throwable e) {
         System.err.println(message);
         if (e != null) {
             e.printStackTrace(System.err);
         }
-        failed = true;
     }
 
     private void delete(Path toDelete) {

diff --git a/build-tools/src/main/java/org/elasticsearch/gradle/ReaperService.java b/build-tools/src/main/java/org/elasticsearch/gradle/ReaperService.java
@@ -80,7 +80,7 @@ void shutdown() {
                 logger.info("Waiting for reaper to exit normally");
                 if (reaperProcess.waitFor() != 0) {
                     Path inputDir = getParameters().getInputDir().get().getAsFile().toPath();
-                    throw new GradleException("Reaper process failed. Check log at " + inputDir.resolve("error.log") + " for details");
+                    throw new GradleException("Reaper process failed. Check log at " + inputDir.resolve("reaper.log") + " for details");
                 }
             } catch (Exception e) {
                 throw new RuntimeException(e);
@@ -111,7 +111,7 @@ private synchronized void ensureReaperStarted() {
                 builder.redirectInput(ProcessBuilder.Redirect.PIPE);
                 File logFile = logFilePath().toFile();
                 builder.redirectOutput(logFile);
-                builder.redirectError(logFile);
+                builder.redirectErrorStream();
                 reaperProcess = builder.start();
             } catch (Exception e) {
                 throw new RuntimeException(e);