misc improvements #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bretello
commented
Apr 29, 2024
•
bretello
commented
- add regression test for HistoricalReader/PythonicReader
- tests: add isolate fixture
- get rid of deprecated "imp" module
- python_reader: use raw strings to define regexes
- use f-string, avoid declaring useless variables
- tox: add 3.12
- tests: add annotations to TestConsole/read_spec
- fix ruff warnings
bretello
force-pushed
the
historicalreader-improvements
branch
from
5904c18
to
7520bee
Compare
bretello
force-pushed
the
historicalreader-improvements
branch
from
7520bee
to
e3efc61
Compare
bretello
force-pushed
the
historicalreader-improvements
branch
from
e3efc61
to
5338031
Compare
|
Ci failing because of codecov ratelimit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.