Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in ReScript #97

Merged
merged 111 commits into from
May 22, 2024
Merged

Rewrite in ReScript #97

merged 111 commits into from
May 22, 2024

Commits on Jan 8, 2024

  1. Blindly convert .ts files to .mjs 

    Also get `ncc` to use the file extension.
    @brettcannon
    brettcannon committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a5294a5 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Move from Jest to Vitest

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a0b1331 View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9a02679 View commit details
    Browse the repository at this point in the history

  3. Set up eslint to use modules

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    48426d1 View commit details
    Browse the repository at this point in the history

  4. Drop tsconfig.json

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    87639ce View commit details
    Browse the repository at this point in the history

  5. Tweak command used to run vitest

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a2cac0a View commit details
    Browse the repository at this point in the history

  6. Update config for ECMAScript version appropriate to Node 20

    @brettcannon
    brettcannon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    17a6ba1 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Update package-lock.json

    @brettcannon
    brettcannon committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ac619d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Drop the build step of CI

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    2b266ea View commit details
    Browse the repository at this point in the history

  2. Bump to @vercel/ncc to 0.38.1

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    5ae9fc8 View commit details
    Browse the repository at this point in the history

  3. Rename index.mjs to index.js to try and deal with an ncc problem … 

    …of using `require`
    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    9025ec7 View commit details
    Browse the repository at this point in the history

  4. Try not specifying the module type

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    3bd8c66 View commit details
    Browse the repository at this point in the history

  5. Move back to index.mjs

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    8914dcc View commit details
    Browse the repository at this point in the history

  6. Minify ncc output

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ccd0c63 View commit details
    Browse the repository at this point in the history

  7. Use file extensions in imports

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    a2cbc57 View commit details
    Browse the repository at this point in the history

  8. Try moving to esbuild for bundling

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    7c9c2dd View commit details
    Browse the repository at this point in the history

  9. Rename output file

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    57497d7 View commit details
    Browse the repository at this point in the history

  10. Explicitly move to dist/index.js

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    b62365e View commit details
    Browse the repository at this point in the history

  11. Don't explicitly say everything is a module

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    8b34e12 View commit details
    Browse the repository at this point in the history

  12. Upgrade http-client

    @brettcannon
    brettcannon committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    fdacb92 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Specify the default glob pattern at the action level instead of the J… 

    …S level
    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    190dee6 View commit details
    Browse the repository at this point in the history

  2. Run npm create rescript-app and clean up npm run commands

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    1b19d6d View commit details
    Browse the repository at this point in the history

  3. Remove some dead code due to moving default glob to action.yml

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b14d28b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'rewrite/mjs' into rewrite/res

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5be604a View commit details
    Browse the repository at this point in the history

  5. Check for .mjs changes in PRs

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2858137 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'rewrite/mjs' into rewrite/res

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3bea908 View commit details
    Browse the repository at this point in the history

  7. Check for changed .res files in PRs

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    028af05 View commit details
    Browse the repository at this point in the history

  8. Drop some lingering TS settings

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    190d74b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'rewrite/mjs' into rewrite/res

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ce0f41c View commit details
    Browse the repository at this point in the history

  10. Add a task for launching the compile watching task

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    927732d View commit details
    Browse the repository at this point in the history

  11. Run npm run res:dev on folder open via a task

    @brettcannon
    brettcannon committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ae13751 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Have the ReScript extension handle the builds

    @brettcannon
    brettcannon committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    00dfcc5 View commit details
    Browse the repository at this point in the history

  2. Delete the empty tasks.json

    @brettcannon
    brettcannon committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    83a0314 View commit details
    Browse the repository at this point in the history

  3. Raw copy matching.mjs to Matching.res

    @brettcannon
    brettcannon committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bb9f429 View commit details
    Browse the repository at this point in the history

  4. Port Matching.hasLabelMatch to ReScript

    @brettcannon
    brettcannon committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    45a4823 View commit details
    Browse the repository at this point in the history

  5. Finish porting to Matching.res

    @brettcannon
    brettcannon committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    baeb092 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Copy gh.mjs over to GH.res

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7d0b627 View commit details
    Browse the repository at this point in the history

  2. Port more of GH.res to ReScript

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    72fec07 View commit details
    Browse the repository at this point in the history

  3. Drop large block of %%raw from GH.mjs 

    Still have some usage of `%%raw` and `%raw`, but now it's much more contained.
    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8a6c877 View commit details
    Browse the repository at this point in the history

  4. Remove ported .mjs files

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0fb8176 View commit details
    Browse the repository at this point in the history

  5. Port index.mjs to ReScript

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    64fdf0a View commit details
    Browse the repository at this point in the history

  6. Drop ported index.mjs

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f0ceb7c View commit details
    Browse the repository at this point in the history

  7. Reformat rescript.json

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d3457d9 View commit details
    Browse the repository at this point in the history

  8. Copy main.mjs into Main.res

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d7da6cd View commit details
    Browse the repository at this point in the history

  9. Add a note about Main.main() not being declared async

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    291f11e View commit details
    Browse the repository at this point in the history

  10. Move isolated code out to ReScript

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a107e03 View commit details
    Browse the repository at this point in the history

  11. List more things to eventually clean up

    @brettcannon
    brettcannon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    08f2dcb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Finish porting main.mjs to Main.res

    @brettcannon
    brettcannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a8fe80b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Update what runs on CI

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2cbaefc View commit details
    Browse the repository at this point in the history

  2. Fix YAML

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f2ed1aa View commit details
    Browse the repository at this point in the history

  3. Fix flags for tormat checking

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ad0e064 View commit details
    Browse the repository at this point in the history

  4. Compile ReScript before running tests

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8bc11a1 View commit details
    Browse the repository at this point in the history

  5. Fix commands to run for testing

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6af6558 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0b29e43 View commit details
    Browse the repository at this point in the history

  7. Drop testing

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5d7af99 View commit details
    Browse the repository at this point in the history

  8. Try to fix scoping

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    87e02d6 View commit details
    Browse the repository at this point in the history

  9. Make types from external much tighter

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e34f1d1 View commit details
    Browse the repository at this point in the history

  10. Touch up comments

    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b042b4e View commit details
    Browse the repository at this point in the history

  11. Turn GH.payloadType into an object to differentiate from `GH.prPayl… 

    …oadType` in order to avoid type annotations
    @brettcannon
    brettcannon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f71ffa5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Use an opaque/abstract type for Octokit objects

    @brettcannon
    brettcannon committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5cd125d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Set up testing using rescript-zora

    @brettcannon
    brettcannon committed May 5, 2024
    Configuration menu
    Copy the full SHA
    e4ea374 View commit details
    Browse the repository at this point in the history

  2. Port Matching tests to rescript-zora

    @brettcannon
    brettcannon committed May 5, 2024
    Configuration menu
    Copy the full SHA
    57add31 View commit details
    Browse the repository at this point in the history

  3. Run tests on CI

    @brettcannon
    brettcannon committed May 5, 2024
    Configuration menu
    Copy the full SHA
    8bdda08 View commit details
    Browse the repository at this point in the history

  4. Build .res files for tests

    @brettcannon
    brettcannon committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d44034b View commit details
    Browse the repository at this point in the history

  5. Write tests for defaults found in action.yml

    @brettcannon
    brettcannon committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a87b9fa View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Tweak how to check for files that weren't formatted

    @brettcannon
    brettcannon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a8184bf View commit details
    Browse the repository at this point in the history

  2. Test format change detection in GHA

    @brettcannon
    brettcannon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    73a941b View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @brettcannon
    brettcannon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bc6ab7b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Thorough tweak to format check in CI

    @brettcannon
    brettcannon committed May 9, 2024
    Configuration menu
    Copy the full SHA
    62c65db View commit details
    Browse the repository at this point in the history

  2. Start of tests for GH.pullRequestPayload()

    @brettcannon
    brettcannon committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dca9824 View commit details
    Browse the repository at this point in the history

  3. Fix attribute name

    @brettcannon
    brettcannon committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7df2661 View commit details
    Browse the repository at this point in the history

  4. Set up tasks.json to build and test things

    @brettcannon
    brettcannon committed May 9, 2024
    Configuration menu
    Copy the full SHA
    530ac21 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Finish writing tests for GH.pullRequestPayload()

    @brettcannon
    brettcannon committed May 10, 2024
    Configuration menu
    Copy the full SHA
    895a014 View commit details
    Browse the repository at this point in the history

  2. Simplify some test code by pulling out shared variables

    @brettcannon
    brettcannon committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a96768c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Add tests for GH.pullRequestLabels()

    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    1f82e04 View commit details
    Browse the repository at this point in the history

  2. Add a comment

    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    907c633 View commit details
    Browse the repository at this point in the history

  3. Set up file watching for test execution using watchexec-cli

    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    b50ba13 View commit details
    Browse the repository at this point in the history

  4. Add a watching task that runs builds and then tests 

    That should avoid running tests when there's a compiler failure.
    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    98cb863 View commit details
    Browse the repository at this point in the history

  5. Make test watching more thorough and accurate

    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    8b6c873 View commit details
    Browse the repository at this point in the history

  6. Simplify tasks.json 

    Drop watching tasks.
    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    57b8bb6 View commit details
    Browse the repository at this point in the history

  7. Normalize names of tasks/scripts/commands 

    Also move to `onchange` to have the file watcher be installable via NPM.
    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    869f0e2 View commit details
    Browse the repository at this point in the history

  8. Update index.js

    @brettcannon
    brettcannon committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0a7dc1c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Write tests for Main.formatFailureMessage()

    @brettcannon
    brettcannon committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b2b1094 View commit details
    Browse the repository at this point in the history

  2. Refactor Main.res for easier testing in the future

    @brettcannon
    brettcannon committed May 13, 2024
    Configuration menu
    Copy the full SHA
    245fc9f View commit details
    Browse the repository at this point in the history

  3. Refactor Main.res for easier testing in the future

    @brettcannon
    brettcannon committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2429e02 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'rewrite/res' of github.com:brettcannon/check-for-change… 

    …d-files into rewrite/res
    @brettcannon
    brettcannon committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6082326 View commit details
    Browse the repository at this point in the history

  5. Add a comment

    @brettcannon
    brettcannon committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b4d2b74 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. More refactorings to make testing easier for Main.res 

    Collect all inputs into a record so that's how that I/O state gets passed around.

Also shift most of the logging out of the helper functions and instead put it in `Main.main()` to mitigate having to test logging I/O.
    @brettcannon
    brettcannon committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e91a35c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Move over to a result-based flow 

    Should hopefully make testing easier
    @brettcannon
    brettcannon committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7b673d7 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Make sure all inputs either are required or have a default value

    @brettcannon
    brettcannon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1332d1e View commit details
    Browse the repository at this point in the history

  2. Explicitly close action.yml file handle in Action_test.res

    @brettcannon
    brettcannon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    da87617 View commit details
    Browse the repository at this point in the history

  3. Add Action.resi so that key names are more controlled for inputs

    @brettcannon
    brettcannon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1b920b3 View commit details
    Browse the repository at this point in the history

  4. Outline tests to write

    @brettcannon
    brettcannon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5858248 View commit details
    Browse the repository at this point in the history

  5. Test when the payload isn't for a pull request

    @brettcannon
    brettcannon committed May 17, 2024
    Configuration menu
    Copy the full SHA
    39edd81 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Test for when a skip label is set

    @brettcannon
    brettcannon committed May 18, 2024
    Configuration menu
    Copy the full SHA
    ee0e061 View commit details
    Browse the repository at this point in the history

  2. Add a test for the prerequisite pattern not matching

    @brettcannon
    brettcannon committed May 18, 2024
    Configuration menu
    Copy the full SHA
    0f44711 View commit details
    Browse the repository at this point in the history

  3. Add a comment

    @brettcannon
    brettcannon committed May 18, 2024
    Configuration menu
    Copy the full SHA
    18517d8 View commit details
    Browse the repository at this point in the history

  4. Write a test for when the check fails

    @brettcannon
    brettcannon committed May 18, 2024
    Configuration menu
    Copy the full SHA
    6797580 View commit details
    Browse the repository at this point in the history

  5. Inline a function

    @brettcannon
    brettcannon committed May 18, 2024
    Configuration menu
    Copy the full SHA
    d4f6ad7 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Change how getInput is kept private

    @brettcannon
    brettcannon committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f991e54 View commit details
    Browse the repository at this point in the history

  2. More idiomatic code for Matching.res

    @brettcannon
    brettcannon committed May 19, 2024
    Configuration menu
    Copy the full SHA
    56d2caf View commit details
    Browse the repository at this point in the history

  3. Add more tests for action.yml

    @brettcannon
    brettcannon committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ffe662c View commit details
    Browse the repository at this point in the history

  4. Make Action.res more idiomatic

    @brettcannon
    brettcannon committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dcd2c40 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Make GH.res more idiomatic

    @brettcannon
    brettcannon committed May 20, 2024
    Configuration menu
    Copy the full SHA
    fc7c433 View commit details
    Browse the repository at this point in the history

  2. Tweak a comment

    @brettcannon
    brettcannon committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ff07b61 View commit details
    Browse the repository at this point in the history

  3. Use currying

    @brettcannon
    brettcannon committed May 20, 2024
    Configuration menu
    Copy the full SHA
    24cbd66 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add a check that when action.yml changes so does README.md

    @brettcannon
    brettcannon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e1498b5 View commit details
    Browse the repository at this point in the history

  2. Not what inputs are optional in the README

    @brettcannon
    brettcannon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ad8213f View commit details
    Browse the repository at this point in the history

  3. Tweak a job name

    @brettcannon
    brettcannon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0562fcc View commit details
    Browse the repository at this point in the history

  4. Temp step to verify skip labels still work

    @brettcannon
    brettcannon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2c1664a View commit details
    Browse the repository at this point in the history

  5. Remove temp test step

    @brettcannon
    brettcannon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2ec1c95 View commit details
    Browse the repository at this point in the history