Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support code for making HTTP requests and processing the responses #89

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Provide support code for making HTTP requests and processing the responses #89

merged 4 commits into from
Dec 14, 2022

Conversation

brettcannon
Copy link
Owner

Closes #75
Closes #77

@brettcannon brettcannon self-assigned this Dec 11, 2022
d3r3kk
d3r3kk approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@d3r3kk d3r3kk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Need to fix the nit the CI is reporting.

Should we include a negative test here as well, showing that the documented assert is raised when you give any non-accepted type? (That might actually be related to the missing ~3.5% coverage perhaps).

@brettcannon
Copy link
Owner Author

@d3r3kk you were right as to why coverage wasn't passing. 😅

@brettcannon brettcannon merged commit 914489e into main Dec 14, 2022
@brettcannon brettcannon deleted the content_type_helper branch December 14, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3r3kk d3r3kk Awaiting requested review from d3r3kk

Assignees

@brettcannon brettcannon

Labels
impact-feature
Projects
None yet
Milestone
No milestone
2 participants
@brettcannon @d3r3kk