-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/exclusion of elements #14
Conversation
Limiting Object Depth Traversal
…tminnie/breakfast-serializer into feature/ExclusionOfElements
…e next depth class now
* @param string $pathName | ||
* @return IsConfigurable | ||
*/ | ||
public function setConfigurationPath($pathName = './config') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better in a default config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly, though I wanted it to run without dicking about with a bootstrap, should probably include the default directory as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Just a thought 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will implement default config and one or two other tweaks in a later pr, it's a good idea, I just need to figure out how to do it neatly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised as #18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Feature/exclusion of elements
@eddiejaoude when you get a moment
Will close #16 and close #6