Better meaning for slashless :github arg.

brettporter · Oct 1, 2012 · 7c8c58e · 7c8c58e
1 parent 8fca868
commit 7c8c58e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/bundler/dsl.rb b/lib/bundler/dsl.rb
@@ -231,7 +231,7 @@ def _normalize_options(name, version, opts)
       end
 
       if github = opts.delete("github")
-        github = "#{github}/#{github}" unless github.include?("/")
+        github = "#{github}/#{name}" unless github.include?("/")
         opts["git"] = "git://github.com/#{github}.git"
       end
 

diff --git a/spec/bundler/dsl_spec.rb b/spec/bundler/dsl_spec.rb
@@ -18,6 +18,13 @@
       github_uri = "git://github.com/rails/rails.git"
       subject.dependencies.first.source.uri.should == github_uri
     end
+
+    it "should interpret slashless 'github:' value as account name" do
+      subject.gem("bundler", :github => "carlhuda")
+      github_uri = "git://github.com/carlhuda/bundler.git"
+      subject.dependencies.first.source.uri.should == github_uri
+    end
+
   end
 
   describe '#method_missing' do