Correctly handle quotes in values. Closes #5

brettstimmerman · Nov 19, 2013 · db690c5 · db690c5
1 parent 76681ea
commit db690c5
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/lib/lexer.js b/lib/lexer.js
@@ -431,13 +431,13 @@ function lex(css) {
     case "'":
       switch (getState()) {
       case 'double-string':
-        if ('"' === ch) {
+        if ('"' === ch && '\\' !== peek(-1)) {
           popState();
         }
         break;
 
       case 'single-string':
-        if ("'" === ch) {
+        if ("'" === ch && '\\' !== peek(-1)) {
           popState();
         }
         break;
@@ -457,7 +457,9 @@ function lex(css) {
         break;
 
       default:
-        pushState('"' === ch ? 'double-string' : 'single-string');
+        if ('\\' !== peek(-1)) {
+          pushState('"' === ch ? 'double-string' : 'single-string');
+        }
       }
 
       buffer += ch;

diff --git a/test/syntax.js b/test/syntax.js
@@ -27,6 +27,27 @@ describe('Syntax', function () {
     });
   });
 
+  describe('strings in values', function () {
+    it('should work', function () {
+      var css = [
+        '.sele {',
+          'content: "hel\\"lo";',
+        '}'
+      ].join('\n');
+
+      ensure(css);
+
+      css = [
+        '.sele {',
+          'voice-family: "\\"}\\"";',
+          'voice-family: inherit;',
+        '}'
+      ].join('\n');
+
+      ensure(css);
+    });
+  });
+
   describe('unexpected braces and semi-colons', function () {
     it('should be ignored', function () {
       var css = [