Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle quotes in values. Closes #5 #6

Merged
merged 1 commit into from
Nov 23, 2013

Conversation

brettstimmerman
Copy link
Owner

@stoyan: Can you think of any other cases?

@stoyan
Copy link

stoyan commented Nov 19, 2013

let me see ...

.klass {
  /* " */
  /*  ' */
  /* \' \" \*/
  content: '"';
  content: '\"';
  content: "'";
  content: "\'";
  content: '/* dude \*/';
  content: '/* ';
  background: url('\"');
}

@stoyan
Copy link

stoyan commented Nov 19, 2013

.klass {
  content: "du\
de"
}

@brettstimmerman
Copy link
Owner Author

Thanks! Updated tests with those cases.

@stoyan
Copy link

stoyan commented Nov 20, 2013

.onemore {
  content: "\\\"";
  content: "\\\'";
  content: "{}";
}

@brettstimmerman
Copy link
Owner Author

Added .onemore to the tests.

brettstimmerman added a commit that referenced this pull request Nov 23, 2013
Correctly handle quotes in values. Closes #5
@brettstimmerman brettstimmerman merged commit ba7b2a8 into master Nov 23, 2013
@brettstimmerman brettstimmerman deleted the fix/quotes_in_values branch November 23, 2013 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants