Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow garbage collection to run regularly by re-queuing itself in the future #37

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

jamesLiAKQA
Copy link
Contributor

This allows garbage collection to run regularly.

RecurringAllGarbageCollectorJob is created to regularly run garbage collection. RecurringAllGarbageCollectorJob will queue all garbage collectors attached to GarbageCollectorService as silverstripe queued job. Afterwards RecurringAllGarbageCollectorJob will queue itself to run again in the number of seconds specified (default 1 day)

RecurringAllGarbageCollectorJob can be automatically created after dev/build by using the QueuedJobDescriptorExtension extension.

README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #37 (5614fee) into master (b3eb238) will decrease coverage by 6.22%.
The diff coverage is 11.76%.

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     95.05%   88.84%   -6.22%     
- Complexity      138      149      +11     
============================================
  Files            11       13       +2     
  Lines           425      457      +32     
============================================
+ Hits            404      406       +2     
- Misses           21       51      +30     
Flag Coverage Δ
unittests 88.84% <11.76%> (-6.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Extensions/QueuedJobDescriptorExtension.php 0.00% <0.00%> (ø)
src/Jobs/GarbageCollectorJob.php 97.22% <ø> (ø)
src/Jobs/RecurringAllGarbageCollectorJob.php 0.00% <0.00%> (ø)
src/GarbageCollectorService.php 95.34% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunnysideup sunnysideup merged commit 0985867 into brettt89:master Jan 16, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants