Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
|
@@ -79,7 +79,7 @@ public class HikariConfig implements HikariConfigMXBean | ||
private String transactionIsolationName; | private String transactionIsolationName; | ||
private String username; | private String username; | ||
private boolean isAutoCommit; | private boolean isAutoCommit; | ||
private boolean isReadOnly; | private Boolean isReadOnly; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
brettwooldridge
Author
Owner
|
|||
private boolean isInitializationFailFast; | private boolean isInitializationFailFast; | ||
private boolean isIsolateInternalQueries; | private boolean isIsolateInternalQueries; | ||
private boolean isRegisterMbeans; | private boolean isRegisterMbeans; | ||
|
@@ -529,12 +529,12 @@ public void addHealthCheckProperty(String key, String value) | ||
healthCheckProperties.setProperty(key, value); | healthCheckProperties.setProperty(key, value); | ||
} | } | ||
|
|
||
public boolean isReadOnly() | public Boolean isReadOnly() | ||
{ | { | ||
return isReadOnly; | return isReadOnly; | ||
} | } | ||
|
|
||
public void setReadOnly(boolean readOnly) | public void setReadOnly(Boolean readOnly) | ||
{ | { | ||
this.isReadOnly = readOnly; | this.isReadOnly = readOnly; | ||
} | } | ||
|
@brettwooldridge Hi Brett, after bumping the hikaricp version to 2.4.0 in Play a couple of tests started to fail because the type of
isReadOnly
has changed (see PR playframework/playframework#5003). This is easy to fix, but I'm wondering why the change.