Bumped HikariCP version to 2.4.0 #5003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotta I've closed and reopen the PR just to trigger a new build. |
|
This is failing due to a compile error. |
|
Here is the error: |
Had to insert a type ascription in a couple of tests to force the conversion of a `java.lang.Boolean` into a `scala.Boolean`. The change was needed because the type of `HikariConfig.isReadOnly` was changed from a primitive boolean into a boxed one (see brettwooldridge/HikariCP@b18c786#commitcomment-12755016) Also, note that HikariCP 2.4.x stream will be binary compatible with 2.4.0 as mentioned in https://groups.google.com/forum/#!topic/play-framework-dev/iqKgOqa3McM
dotta
force-pushed
the
bump-hikaricp-version
branch
from
dce7c39
to
b08543c
Compare
|
I'm closing this as there will be a hikaricp 2.4.1 release soon (and some of the changes in this PR won't be needed anymore). For context see brettwooldridge/HikariCP@b18c786#commitcomment-12777354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, note that HikariCP 2.4.x stream will be binary compatible with 2.4.0 as
mentioned in
https://groups.google.com/forum/#!topic/play-framework-dev/iqKgOqa3McM
do NOT backport :-)