Do not log warning about idleTimeout unless minimumIdle is less than …

…maxPoolSize (because otherwise it does not apply)
brettwooldridge · Jan 22, 2019 · c742e86 · c742e86
1 parent b183aa1
commit c742e86
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/com/zaxxer/hikari/HikariConfig.java b/src/main/java/com/zaxxer/hikari/HikariConfig.java
@@ -973,7 +973,7 @@ private void validateNumerics()
          maxLifetime = MAX_LIFETIME;
       }
 
-      if (idleTimeout + SECONDS.toMillis(1) > maxLifetime && maxLifetime > 0) {
+      if (idleTimeout + SECONDS.toMillis(1) > maxLifetime && maxLifetime > 0 && minIdle < maxPoolSize) {
          LOGGER.warn("{} - idleTimeout is close to or more than maxLifetime, disabling it.", poolName);
          idleTimeout = 0;
       }