Added Support For beginRequest and endRequest #2079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettwooldridge Please take a look |
1 similar comment
|
@brettwooldridge Please take a look |
akashchouhan16
suggested changes
Jul 7, 2023
akashchouhan16
approved these changes
Jul 7, 2023
|
Can this PR please be merged? |
lfbayer
requested changes
Oct 22, 2023
Comment on lines
+83
to
+86
| DatabaseMetaData dm = connection.getMetaData(); | ||
| if (dm!=null){ | ||
| if (dm.getJDBCMajorVersion() > 4 || | ||
| (dm.getJDBCMajorVersion() == 4 && dm.getJDBCMinorVersion() >= 3)) { |
There was a problem hiding this comment.
This logic should not be executed every time. Can this be moved somewhere so the calculation of if the feature is supported is only run once. Calling getMetaData might not be cheap.
There was a problem hiding this comment.
This comment has been addressed in pull request #2126
|
Closing this as the work is being continued on #2126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2071 Added support of beginRequest and endRequest from JDBC 4.3 onwards.
Both these calls function to let the driver know when a connection is checked out of the pool and back into the pool.These boundaries can help driver for load balancing and other stuff. These functions are driver specific and may not do anything.