Use Job objects in lieu of a shutdown hook on Windows. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown hooks have bad behavior on Windows. Using Windows Job objects ensure child processes die when the parent process (the NuProcess caller) dies, regardless of the circumstances that caused the JVM running NuProcess died.
doctorpangloss
force-pushed
the
master
branch
from
508e8f3
to
a484ea9
Compare
bturner
reviewed
Jan 6, 2022
| } | ||
|
|
||
| if (!AssignProcessToJobObject(hJob, getPidHandle())) { | ||
| throw new RuntimeException("Failed to attach to job " + Native.getLastError()); |
There was a problem hiding this comment.
You're almost certainly going to leak a process if this happens. start will catch this exception and (from my own changes) log it, and then return without the process ever being terminated.
bturner
reviewed
Jan 6, 2022
| @@ -226,6 +222,8 @@ public void setProcessHandler(NuProcessHandler processHandler) | |||
|
|
|||
| NuProcess start(List<String> commands, String[] environment, Path cwd) | |||
There was a problem hiding this comment.
Shouldn't you also make changes to run below so it uses jobs too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown hooks have bad behavior on Windows. Using Windows Job objects
ensure child processes die when the parent process (the NuProcess
caller) dies, regardless of the circumstances that caused the JVM
running NuProcess died.