Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Update ECS with new rules #41

Open
1 of 3 tasks
krzysztofrewak opened this issue Sep 3, 2020 · 0 comments · Fixed by #45
Open
1 of 3 tasks

Update ECS with new rules #41

krzysztofrewak opened this issue Sep 3, 2020 · 0 comments · Fixed by #45
Labels
environment All environment-related things new feature New feature or request
Projects
Environment

Comments

@krzysztofrewak
Copy link
Contributor

krzysztofrewak commented Sep 3, 2020 •
edited
Loading

To do:

  • check if doublequotes were used instead of single ones in strings
  • enforce type hinting and return types in anonymous functions (arrow ones too!)
  • forbid using comments in code (especially commented lines of code)

Any other suggestions are welcomed.
@krzysztofrewak krzysztofrewak added new feature New feature or request environment All environment-related things labels Sep 3, 2020
@krzysztofrewak krzysztofrewak added this to To do in Environment via automation Sep 3, 2020
krzysztofrewak added a commit that referenced this issue Sep 7, 2020
@krzysztofrewak
#41 - double qoutes fixer enabled
7759063
krzysztofrewak added a commit that referenced this issue Sep 7, 2020
@krzysztofrewak
Merge remote-tracking branch 'origin/develop' into #41-double-quotes-…
0901c6f 
…fixer

# Conflicts:
#	composer.lock
krzysztofrewak added a commit that referenced this issue Sep 7, 2020
@krzysztofrewak
#41 - merge conflict solved
1953c14
krzysztofrewak added a commit that referenced this issue Sep 8, 2020
@krzysztofrewak
#41 - double quotes fixer enabled
cf2a88a 
* #41 - double qoutes fixer enabled

* #41 - merge conflict solved
@krzysztofrewak krzysztofrewak linked a pull request Sep 12, 2020 that will close this issue
#41 - double quotes fixer enabled #45
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
environment All environment-related things new feature New feature or request
Projects
Environment
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#41 - double quotes fixer enabled brewmap/brewmap
1 participant
@krzysztofrewak