Some proxy-related fixes in Winetricks plugin #83

Merged
merged 3 commits into from Aug 10, 2016

Projects

None yet

2 participants

@kakurasan
Contributor
kakurasan commented Aug 6, 2016 edited
  • Correct proxy-related environment variables in Winetricks plugin
    • Wget uses lowercase environment variables (e.g. http_proxy)
    • When Wget downloads Winetricks (HTTPS URL), https_proxy is used
  • Use env command in the command line to download Winetricks
    • xterm does not start if proxy host is set
  • Support proxy username/password in Winetricks plugin
kakurasan added some commits Aug 6, 2016
@kakurasan kakurasan Correct proxy-related environment variables in Winetricks plugin
Proxy-related environment variables must be lowercase.
When Wget downloads Winetricks (HTTPS URL), https_proxy is used.
b556acc
@kakurasan kakurasan Use env command in the command line to download Winetricks
xterm does not start if proxy host is set. This commit fixes the issue.
1548bb9
@kakurasan kakurasan Support proxy username/password in Winetricks plugin 2e5c927
@brezerk
Owner
brezerk commented Aug 8, 2016

thank you, will take a look on the changes today evening.

@brezerk brezerk added the Improvement label Aug 8, 2016
@brezerk brezerk added this to the 1.3.2 milestone Aug 8, 2016
@brezerk brezerk self-assigned this Aug 8, 2016
@brezerk brezerk merged commit b5e8fa8 into brezerk:master Aug 10, 2016
@brezerk
Owner
brezerk commented Aug 10, 2016

Looks good. Thanks for a pull request!

btw: feel free to add your self to the authors/about files. or let me know if you would like me to add your contact details.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment