Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some proxy-related fixes in Winetricks plugin #83

Merged
merged 3 commits into from Aug 10, 2016

Conversation

@kakurasan
Copy link
Contributor

@kakurasan kakurasan commented Aug 6, 2016

  • Correct proxy-related environment variables in Winetricks plugin
    • Wget uses lowercase environment variables (e.g. http_proxy)
    • When Wget downloads Winetricks (HTTPS URL), https_proxy is used
  • Use env command in the command line to download Winetricks
    • xterm does not start if proxy host is set
  • Support proxy username/password in Winetricks plugin
kakurasan added 3 commits Aug 6, 2016
Proxy-related environment variables must be lowercase.
When Wget downloads Winetricks (HTTPS URL), https_proxy is used.
xterm does not start if proxy host is set. This commit fixes the issue.
@brezerk
Copy link
Owner

@brezerk brezerk commented Aug 8, 2016

thank you, will take a look on the changes today evening.

@brezerk brezerk added this to the 1.3.2 milestone Aug 8, 2016
@brezerk brezerk self-assigned this Aug 8, 2016
@brezerk brezerk merged commit b5e8fa8 into brezerk:master Aug 10, 2016
@brezerk
Copy link
Owner

@brezerk brezerk commented Aug 10, 2016

Looks good. Thanks for a pull request!

btw: feel free to add your self to the authors/about files. or let me know if you would like me to add your contact details.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants