Some proxy-related fixes in Winetricks plugin #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kakurasan
commented
Aug 6, 2016
•
kakurasan
commented
- Correct proxy-related environment variables in Winetricks plugin
- Wget uses lowercase environment variables (e.g. http_proxy)
- When Wget downloads Winetricks (HTTPS URL), https_proxy is used
- Use env command in the command line to download Winetricks
- xterm does not start if proxy host is set
- Support proxy username/password in Winetricks plugin
Proxy-related environment variables must be lowercase. When Wget downloads Winetricks (HTTPS URL), https_proxy is used.
xterm does not start if proxy host is set. This commit fixes the issue.
|
thank you, will take a look on the changes today evening. |
|
Looks good. Thanks for a pull request! btw: feel free to add your self to the authors/about files. or let me know if you would like me to add your contact details. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.