Library refactor #3
Conversation
There was a problem hiding this comment.
Thank you so much. Looks good for now!.
Long term we should either inject the logger or figure out the "Pythonic" way to do it, to avoid a global. There are some object/binary files in lzss that I'll clean up for ya. And, I guess the use of lib is sort of non-Pythonic as well although I don't mind it.
I'd also, of course, eventually like to factor these file-based utilities into "true" library functions - instead of a "main" , a function that takes the binary input and output, to delegate the file handling to the consumer. In this way we'll eventually be able to build a consumer/UI that doesn't require intermediate files and can do all the processing in memory.
Regardless, none of these are blocking and this is better than where we're at! I will push one more commit to this branch to remove the binaries and then merge this PR, thank you!
|
|
||
| rootLogger = logging.getLogger() | ||
|
|
||
| def main(inputfile = None, outputfile = None, loglevel=logging.INFO): |
There was a problem hiding this comment.
Long term we might as well inject the logger with a default rootLogger = logging.getLogger() here, for example, to avoid the global. Or find whatever the more Pythonic way to do this is. Either way, not blocking merge.
Massive changes.
Suggestion would be to verify functionality first. And perhaps branch current master as a version so it can be checkpointed.
Overview:
Individual scripts for checksum, encryption, and compression have been moved into lib directory as libraries that can be imported.
VW_Flash.py is a single point of entry into those operations.