Items - SkipCustomActionForItemThatHasNoActions

brian-dot-net · Dec 12, 2018 · 8aee0a1 · 8aee0a1
1 parent 9d5429b
commit 8aee0a1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/core/src/Item.cs b/core/src/Item.cs
@@ -19,7 +19,7 @@ public bool Do(MessageBus bus, Word verb, Word noun)
 
         protected virtual bool DoCore(MessageBus bus, Word verb, Word noun)
         {
-            return true;
+            return false;
         }
     }
 }
diff --git a/core/test/ItemsTest.cs b/core/test/ItemsTest.cs
@@ -142,6 +142,27 @@ public void SkipCustomActionForItemThatCannotHandleIt()
             messages.Should().ContainSingle().Which.Should().Be("Don't CONSUME the BALL");
         }
 
+        [Fact]
+        public void SkipCustomActionForItemThatHasNoActions()
+        {
+            MessageBus bus = new MessageBus();
+            List<string> messages = new List<string>();
+            bus.Subscribe<OutputMessage>(m => messages.Add(m.Text));
+            Items items = new Items(bus);
+            items.Drop("ball", new TestItemNoActions());
+
+            items.Activate();
+            bus.Subscribe<SentenceMessage>(m => messages.Add($"Don't {m.Verb} the {m.Noun}"));
+            bus.Send(new SentenceMessage(new Word("eat", "CONSUME"), new Word("ball", "BALL")));
+
+            messages.Should().ContainSingle().Which.Should().Be("Don't CONSUME the BALL");
+        }
+
+        private sealed class TestItemNoActions : Item
+        {
+            public override string ShortDescription => "a dull item";
+        }
+
         private sealed class TestItem : Item
         {
             public override string ShortDescription => "a test item";