FeatureMetric default combine fix

brian-team · Sep 15, 2019 · 8ad2e35 · 8ad2e35
1 parent f87099f
commit 8ad2e35
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/brian2modelfitting/modelfitting/metric.py b/brian2modelfitting/modelfitting/metric.py
@@ -228,7 +228,7 @@ def __init__(self, traces_times, feat_list, weights=None, combine=None):
 
         if combine is None:
             def combine(x, y):
-                return x - y
+                return abs(x - y)
         self.combine = combine
 
         if weights is None:
@@ -258,7 +258,7 @@ def feat_to_err(self, d1, d2):
             x = d1[key]
             y = d2[key]
             d[key] = self.combine(x, y) * self.weights[key]
-            
+
         for k, v in d.items():
             err += sum(v)