Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup deprecation warnings #301

Merged
merged 4 commits into from
Feb 2, 2017
Merged

Cleanup deprecation warnings #301

merged 4 commits into from
Feb 2, 2017

Conversation

shortdudey123
Copy link
Contributor

No description provided.

@shortdudey123
Copy link
Contributor Author

@brianbianco any thoughts?

@shortdudey123
Swtich from node.set to default/override
3a4474c 
`node.set` is deprecated
@shortdudey123
Clean up CHEF-3694 warnings
76586b6 
`WARN: Cloning resource attributes for execute[reload-systemd] from prior resource (CHEF-3694)`
@shortdudey123
Clean up user creation warnings
b6d1bdd 
```
supports { manage_home: true } on the user resource is deprecated and will be removed in Chef 13, set manage_home: true instead at 2 locations:
    - /var/chef/cache/cookbooks/redisio/providers/configure.rb:100:in `block (3 levels) in configure'
    - /var/chef/cache/cookbooks/redisio/providers/sentinel.rb:45:in `block (3 levels) in configure'
```
@shortdudey123
Copy link
Contributor Author

@brianbianco can you review this when you have a sec? This will help keep the cookbook from breaking in April w/ chef 13

@brianbianco
Copy link
Contributor

Is there a reason the switch from .set to default / override is bundled up in the same PR as changing the managed home for chef 13? It feels like the switching off .set could potentially break things for some people. Although I don't think anybody would be relying on the persistence of the data, somebody could be.

@shortdudey123
Copy link
Contributor Author

Outside of the spec testing, the only .set change is in recipes/configure.rb. I will use .normal instead since its the same as .set, but generally speaking attribute persistence is not recommended unless really needed. So eventually that will need to be changed, but it is a breaking change.

@shortdudey123
Copy link
Contributor Author

@brianbianco updated :)

@brianbianco
Copy link
Contributor

I agree that attribute persistence should be eliminated, but like you said the breaking change is what i was lookinn to avoid. Breaking changes should usually be their own PR instead of tucked inside others.

@brianbianco brianbianco merged commit 63af45a into sous-chefs:master Feb 2, 2017
@shortdudey123
Copy link
Contributor Author

True, will remember that for the future
thanks!

@shortdudey123 shortdudey123 deleted the cleanup_warnings branch February 2, 2017 18:27
@shortdudey123 shortdudey123 added this to the 2.6.0 milestone Apr 25, 2017
@shortdudey123 shortdudey123 changed the title Cleanup warnings Cleanup deprecation warnings Apr 26, 2017
shortdudey123 added a commit that referenced this pull request May 10, 2017
@shortdudey123
Release 2.6.0
545c5f6 
- Update 'bind' config comments ([#293](#293))
- Add disable_os_default recipe ([#224](#224))
- Use the config's ulimits if set and is > max_clients ([#234](#234))
- Add Travis config ([#299](#299))
- Fix test failures (FoodCritic and Rubocop) ([#298](#298))
- Fix TravisCI builds ([#300](#300))
- Add repl-backlog-size, repl-backlog-ttl, and aof-load-truncated options ([#278](#278))
- Add sentinel_bind to bind sentinel to different IPs ([#306](#306))
- Cleanup deprecation warnings ([#301](#301))
- Fix version detection with epoch version numbers from deb/ubuntu ([#294](#294))
- Restrict VM redis config to <= 2.4 ([#322](#322))
- Rename_commands should be checked for nil before empty ([#311](#311))
- Fixup foodcritic, rubocop, and kitchen testing ([#324](#324))
  - Note: this drops support for Chef < 11
- Add min-slaves redis options ([#313](#313))
- Allow /etc/init start after sigterm from system or user ([#310](#310))
- Check user existence with Etc, not ohai node attributes ([#303](#303))
- Various systemd-related improvements ([#302](#302))
- Update serverspec testing with correct OS's for systemd ([#329](#329))
- Add kitchen-dokken testing to Travis ([#330](#330))
- Add fedora-25 to kitchen testing and clean up kitchen config ([#331](#331))
- Fix systemd paths for sentinel service ([#332](#332))
- Add redis-package and sentinel to Travis kitchen verify ([#334](#334))
- Add breadcrumb-file creation condition as attribute ([#268](#268))
- Fix cluster options in README ([#333](#333))
- Fix systemd loader to use descriptors instead of max_clients+32 ([#338](#338))
- Add SELinux support ([#305](#305))
- Make source of redis.conf template configurable ([#341](#341))
- Support sentinel notification-script and client-reconfig-script ([#342](#342))
@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shortdudey123 @brianbianco