Chef 13 compatibility

[shayangz]

Minor changes to fix Chef 13 compatibility issues.

[vitalis]

👍

[mateuszkwiatkowski]

What's needed to merge this PR? I'll be happy to help.

[nishiki]

I tested this patch with chef 13 and it works.
Can you merge this PR ?

Thanks

[brianbianco]

more importantly, will this change break compatibility with chef12?

[nishiki]

No, it's intended to works with chef 12, the point is the PR is stuck in silence.

[brianbianco]

I understand that it's stuck, the operative question was simply

Does this provide compatibility for newer versions without breaking it for older. If the answer is yes, then it's fine to be merged.

[nishiki]

I see that the automated Travis check runs with Chef 12, isn't it enough to validate?

[brianbianco]

It's always nice if somebody tests it locally and confirms as well since the test suite is far from perfect. I can merge now and we will just deal with the any issues that pop up though.

[rambler]

FWIW, this works for me (I'm using berkshelf to checkout the commit with the merge), in the context of sensu with Chef 13. I vote for a release!

[jarrettj]

👍 +1

[rmoriz]

@brianbianco can you please release the master branch to chef's supermarket?

[eren]

I am using this cookbook for my pet project. I tried this change with Chef version 13.5.3 and it's working perfectly fine. Please release 2.6.2 version of this cookbook and upload it to supermarket. @brianbianco

I had to spend hours of debugging because I was originally using supermarket to install redisio cookbook and got the following error:

NameError: uninitialized constant Chef::Resource::RedisioConfigure

I checked out this repository master branch and start grepping strings. I couldn't find any reference because the code was already fixed and merged. However, the version string is still 2.6.1. I later realized this github issue and saw that PR was merged. I installed this cookbook from git and it's now working. This is the line of my Berksfile:

cookbook 'redisio', '~> 2.6.1', git: "https://github.com/brianbianco/redisio.git", branch: "master"

I hope this explanation helps people who got similar error until the code is released in supermarket.

[thomasriley]

Could someone cut a release of this to supermarket? Seems a shame not to release when someone has put the time in to make this work on Chef 13.

Thanks!

[ssmlt]

@brianbianco
Hello, are you able to bump cookbook version in metadata?
Then Chef supermarket will take that release.
Because you merged the fix more than half year ago, but still not in supermarket :(

[majormoses]

@brianbianco if you need some help maintaining this let me know I am more than happy to help out as this is currently blocking us on a cookbook I maintain for sensu.

[brianbianco]

This sounds like a good plan. I can grant your github perms as well as chef supermarket. Feel free to shoot me a personal email if you want Brian.bianco@gmail.com

…

On Mar 27, 2018, at 16:14, Ben Abrams ***@***.***> wrote: @brianbianco if you need some help maintaining this let me know I am more than happy to help out as this is currently blocking us on a cookbook I maintain for sensu. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[majormoses]

released:

• https://github.com/brianbianco/redisio/tree/v2.7.0
• https://supermarket.chef.io/cookbooks/redisio/versions/2.7.0

[scalp42]

@shayangz 💪

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.