refactor: simplify the escapeIdentifier logic

brianc · Jul 29, 2018 · 00d749c · 00d749c · benjie · May 8, 2019
1 parent 6c840aa
commit 00d749c
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -305,20 +305,7 @@ Client.prototype.getTypeParser = function (oid, format) {
 
 // Ported from PostgreSQL 9.2.4 source code in src/interfaces/libpq/fe-exec.c
 Client.prototype.escapeIdentifier = function (str) {
-  var escaped = '"'
-
-  for (var i = 0; i < str.length; i++) {
-    var c = str[i]
-    if (c === '"') {
-      escaped += c + c
-    } else {
-      escaped += c
-    }
-  }
-
-  escaped += '"'
-
-  return escaped
+  return '"' + str.replace(/"/g, '""') + '"'
 }
 
 // Ported from PostgreSQL 9.2.4 source code in src/interfaces/libpq/fe-exec.c