skip TLS SNI if host is IP address (do not set servername option in t…

…ls.connect)
brianc · May 8, 2019 · d3c8eba · d3c8eba
1 parent 4b530a9
commit d3c8eba
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/connection.js b/lib/connection.js
@@ -91,9 +91,8 @@ Connection.prototype.connect = function (port, host) {
         return self.emit('error', new Error('There was an error establishing an SSL connection'))
     }
     var tls = require('tls')
-    self.stream = tls.connect({
+    let options = {
       socket: self.stream,
-      servername: host,
       checkServerIdentity: self.ssl.checkServerIdentity || tls.checkServerIdentity,
       rejectUnauthorized: self.ssl.rejectUnauthorized,
       ca: self.ssl.ca,
@@ -103,7 +102,12 @@ Connection.prototype.connect = function (port, host) {
       cert: self.ssl.cert,
       secureOptions: self.ssl.secureOptions,
       NPNProtocols: self.ssl.NPNProtocols
-    })
+    };
+    if( net.isIP(host) === 0 ) {
+      options.servername = host;
+    }
+
+    self.stream = tls.connect(options);
     self.attachListeners(self.stream)
     self.stream.on('error', reportStreamError)