Support "true" as string for ssl (#2407)

Fixes 2406
brianc · Nov 11, 2020 · ebe412c · ebe412c
1 parent 4d203ae
commit ebe412c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/pg/lib/connection-parameters.js b/packages/pg/lib/connection-parameters.js
@@ -80,6 +80,11 @@ class ConnectionParameters {
 
     this.ssl = typeof config.ssl === 'undefined' ? readSSLConfigFromEnvironment() : config.ssl
 
+    if (typeof this.ssl === 'string') {
+      if (this.ssl === 'true') {
+        this.ssl = true
+      }
+    }
     // support passing in ssl=no-verify via connection string
     if (this.ssl === 'no-verify') {
       this.ssl = { rejectUnauthorized: false }

diff --git a/packages/pg/test/unit/connection-parameters/creation-tests.js b/packages/pg/test/unit/connection-parameters/creation-tests.js
@@ -257,7 +257,6 @@ test('libpq connection string building', function () {
   })
 
   test('password contains  < and/or >  characters', function () {
-    return false
     var sourceConfig = {
       user: 'brian',
       password: 'hello<ther>e',
@@ -308,6 +307,11 @@ test('libpq connection string building', function () {
     assert(c.ssl, 'Client should have ssl enabled via defaults')
   })
 
+  test('coercing string "true" to boolean', function () {
+    const subject = new ConnectionParameters({ ssl: 'true' })
+    assert.strictEqual(subject.ssl, true)
+  })
+
   test('ssl is set on client', function () {
     var sourceConfig = {
       user: 'brian',