Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Buffer(str) is deprecated, use Buffer.from(str) instead #1017

Closed
wants to merge 1 commit into from
Closed

new Buffer(str) is deprecated, use Buffer.from(str) instead #1017

wants to merge 1 commit into from

Conversation

ignitenet-martynas
Copy link
Contributor

https://nodejs.org/dist/latest-v6.x/docs/api/buffer.html#buffer_new_buffer_str_encoding says new Buffer(str) is deprecated and Buffer.from(str) should be used instead. Sorry I missed that in my first pull request.

@brianc
Copy link
Owner

brianc commented Jun 20, 2016

I appreciate the thought here but this breaks backwards compatibility with a lot of versions of node. If Buffer(str) is fully removed or there is a suitable alternative which is not deprecated which works on all node environments I'll happily merge something, but breaking compat w/ so many versions of node is a no-go right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants