windows build

[booo]

Seems like we fixed the windows build. I hope I did not broke any other build :) Linux works here on 0.8.1. Any mac users out there?

#165

Best Regards
Philipp

[brianc]

I really appreciate this. I'm on my honeymoon right now so I cannot test this until I get home. As soon as I get back I'll test, merge, and release new version. 1 week.

[3124mike]

I can't build this on MacOs 10.5.8. I haven't installed pg before, so I'm not sure if this new build is the problem. I get:

:~ mike$ npm install pg
npm http GET https://registry.npmjs.org/pg
npm http 304 https://registry.npmjs.org/pg
npm http GET https://registry.npmjs.org/generic-pool/1.0.12
npm http 304 https://registry.npmjs.org/generic-pool/1.0.12

> pg@0.8.4 install /Users/mike/node_modules/pg
> node-gyp rebuild || (exit 0)

  CXX(target) Release/obj.target/binding/src/binding.o
  SOLINK_MODULE(target) Release/binding.node
i686-apple-darwin9-g++-4.0.1: -install_name only allowed with -dynamiclib
make: *** [Release/binding.node] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/Cellar/node/0.8.11/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:219:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:96:17)
gyp ERR! stack     at Process._handle.onexit (child_process.js:678:10)
gyp ERR! System Darwin 9.8.0
gyp ERR! command "node" "/usr/local/Cellar/node/0.8.11/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mike/node_modules/pg
gyp ERR! node -v v0.8.11
gyp ERR! node-gyp -v v0.6.11
gyp ERR! not ok 
pg@0.8.4 node_modules/pg
└── generic-pool@1.0.12

I get the same thing with npm -g install pg.

[3124mike]

Despite these build errors, pg seems to be working okay.

[brianc]

I tested linux and os x builds last night. They pass! Thanks - will release new version this evening. 👍