Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over on #227 Brian said:
This change would make it possible for any-db to remove the adapter layer for postgres and expose (patched) Client objects directly. The change is motivated by the way ConnectionPool.query works. The pool is able to return a
QueryAdapter
synchronously becauseconnection.query
accepts it as an optional parameter.In this patch I've added support to the pure-js driver for separating initialization and construction in
Query
objects, which enables Client.query) to use aquery_object
from the config. If the general idea makes sense to you I'll try and do the same for the NativeQuery object.