Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a NODE_MODULE() statement; fixes #222 #255

Merged
merged 1 commit into from
Jan 24, 2013
Merged

Conversation

booo
Copy link
Contributor

@booo booo commented Jan 24, 2013

No description provided.

@brianc
Copy link
Owner

brianc commented Jan 24, 2013

sweet - merging. It builds now - but dies almost right away in testing on pg@9.1.4 with

make[1]: Leaving directory `/home/bmc/src/node-postgres/build'
gyp info ok 
***Testing native bindings***
callback-api-tests.js.node: ../deps/uv/src/unix/core.c:648: uv__io_stop: Assertion `loop->watchers[w->fd] == w' failed.
xargs: node: terminated by signal 6
make: *** [test-native] Error 125

I wont have time to look at this until this evening or perhaps tomorrow, but at least we're on the right path. Thanks!

brianc added a commit that referenced this pull request Jan 24, 2013
add a NODE_MODULE() statement; fixes #222
@brianc brianc merged commit a24102c into brianc:master Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants