Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add ssl query string to the connection string parser #275 #276

Merged
merged 1 commit into from Jun 30, 2013

Conversation

2 participants
Contributor

bryanburgers commented Feb 21, 2013

This commit only addresses the issue in connection-parameters.js, which looks like it will boil up to the JavaScript client. A quick look at the native client shows that it's using connection-parameters.js, but I don't know enough about that part of the project to determine if that will make a difference there.

Contributor

bryanburgers commented Feb 21, 2013

I wasn't sure if I should use ssl=true or something more standard like sslmode=required. It looked like the code wasn't using sslmode, though, so I didn't want to specify something in the connection string that couldn't be backed up by the code.

@brianc brianc added a commit that referenced this pull request Jun 30, 2013

@brianc brianc Merge pull request #276 from bryanburgers/connection-url-ssl
Add ssl query string to the connection string parser #275
5806afc

@brianc brianc merged commit 5806afc into brianc:master Jun 30, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment