Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a JS array instead of an array literal where SQL expects an array #278

Merged
merged 3 commits into from
Feb 22, 2013

Conversation

adunstan
Copy link
Contributor

Constructing postgres array literals is tedious and error prone. This does the work for you (except for type box, which uses a different separator in array literals).

@brianc
Copy link
Owner

brianc commented Feb 22, 2013

this looks good to me & passes tests - I don't use array types myself so I'm pretty unbiased on this. If you could be so kind as to clean up those few small code-style things I commented on I'll merge this lickety split! Thanks. 👍

@adunstan
Copy link
Contributor Author

Will do. I'm a Postgres committer, so I use a lot of its facilities :-)
You'll probably see a lot of pull requests from me in the near future -
I have a client who has just switched technology stacks, with Postgres
being the only thing they kept, and your stuff is front and center for them.

Keep up the good work.

cheers

andrew

On 02/21/2013 09:44 PM, Brian C wrote:

this looks good to me & passes tests - I don't use array types myself
so I'm pretty unbiased on this. If you could be so kind as to clean up
those few small code-style things I commented on I'll merge this
lickety split! Thanks. 👍


Reply to this email directly or view it on GitHub
#278 (comment).

@noosxe
Copy link

noosxe commented Feb 22, 2013

This thing will be really useful

@brianc
Copy link
Owner

brianc commented Feb 22, 2013

@adunstan awesome! Thank you. 👍 Lemme know if you have any specific things you'd like help with -- I'm generally avaiable on gchat @ brian.m.carlson@gmail.com

brianc added a commit that referenced this pull request Feb 22, 2013
Allow passing a JS array instead of an array literal where SQL expects an array
@brianc brianc merged commit c6d5f43 into brianc:master Feb 22, 2013
@brianc
Copy link
Owner

brianc commented Feb 22, 2013

pushed new version w/ patch to npm @ v0.13.1

ctavan added a commit to ctavan/FastLegS that referenced this pull request Feb 26, 2013
node-postgres now correctly handles arrays as query-parameters as of
brianc/node-postgres#278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants