Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for #2642 - pg-cursor .close() never returns after connection lost #2806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/pg-cursor/test/error-handling.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,24 @@ describe('error handling', function () {
})
})
})

it('can continue after connection lost', function (done) {
const client = new pg.Client()
client.connect()
const cursor = client.query(new Cursor('SELECT NOW()'))
cursor.read(1, function (err) {
// Simulate a connection dropout by disconnecting.
client.end(function (err) {
assert.ifError(err)
// Try to close the cursor as if we didn't know the connection had
// dropped out.
cursor.close(function (err) {
assert.ifError(err)
done()
})
})
})
})
})

describe('read callback does not fire sync', () => {
Expand Down