Fix connection string parsing for overriden hosts #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
changed the title
This corresponds to what was line 48 previously, see https://github.com/brianc/node-postgres/pull/2971/files#diff-08a5e82487ebd9b43751630019753901fae0a111f8d009ad2e9d194445e96922L48
petebacondarwin
approved these changes
May 16, 2023
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
|
Hey thanks for this! ❤️ |
|
Hey, could this fix be published? |
|
For sure! Thought I did, sorry!
…On Thu, Jun 22, 2023 at 9:27 AM Ivan Tereshchenkov ***@***.***> wrote:
Hey, could this fix be published?
—
Reply to this email directly, view it on GitHub
<#2977 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMHIIHKTU56IDGJMVKABTXMRI4BANCNFSM6AAAAAAYDQUXFI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
thijs
pushed a commit
to thijs/node-postgres
that referenced
this pull request
Aug 1, 2023
* Add failing test * Fix test This corresponds to what was line 48 previously, see https://github.com/brianc/node-postgres/pull/2971/files#diff-08a5e82487ebd9b43751630019753901fae0a111f8d009ad2e9d194445e96922L48 * Update packages/pg-connection-string/index.js Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> --------- Co-authored-by: Brian C <brian.m.carlson@gmail.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2976