Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (ci): add node v20 to build matrix #3148

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Feb 19, 2024

Per https://nodejs.org/en/about/previous-releases, node v20 is "active".

pg-native tests are skipped on Node 20 TODO because pg-native doesn't support node 20?

@brianc
Copy link
Owner

brianc commented Mar 13, 2024

Appreciate your thought here! This got added on another PR actually...but thank you! sorry for the delay ❤️

@brianc brianc closed this Mar 13, 2024
@brianc brianc reopened this Mar 13, 2024
@brianc
Copy link
Owner

brianc commented Mar 13, 2024

Oopps! My bad - it actually did not get added. I can add it if you want. Otherwise you'll need to rebase here and pick up the fixes that were done on master to make CI pass. 😅

@alxndrsn
Copy link
Contributor Author

@brianc 👍 should be fixed

@alxndrsn
Copy link
Contributor Author

Hmm failing no node 20:

***Testing native bindings***

changed 2 packages, and audited 1087 packages in 5s

74 packages are looking for funding
  run `npm fund` for details

28 vulnerabilities (11 low, 6 moderate, 5 high, 6 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value
evented-api-tests.jsMessage: Cannot find module 'pg-native'
Require stack:
- /home/runner/work/node-postgres/node-postgres/packages/pg/lib/native/client.js
- /home/runner/work/node-postgres/node-postgres/packages/pg/lib/native/index.js
- /home/runner/work/node-postgres/node-postgres/packages/pg/test/native/evented-api-tests.js
Error: Cannot find module 'pg-native'
Require stack:
- /home/runner/work/node-postgres/node-postgres/packages/pg/lib/native/client.js
- /home/runner/work/node-postgres/node-postgres/packages/pg/lib/native/index.js
xargs: node: exited with status 255; aborting
- /home/runner/work/node-postgres/node-postgres/packages/pg/test/native/evented-api-tests.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/home/runner/work/node-postgres/node-postgres/packages/pg/lib/native/client.js:7:12)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)

make: *** [Makefile:43: test-native] Error 124

@alxndrsn
Copy link
Contributor Author

Adding NODE_DEBUG=module breaks the build on other node versions too 🤔

@alxndrsn
Copy link
Contributor Author

On failing builds, @npm i --no-save pg-native does not install anything:

working

...
added 10 packages, changed 5 packages, and audited 1097 packages in 8s

broken

...
changed 2 packages, and audited 1087 packages in 6s

@alxndrsn
Copy link
Contributor Author

pg-native build fails on node 20; perhaps that is related. Ref:

Maybe related to #2955?

@alxndrsn alxndrsn mentioned this pull request Mar 15, 2024
@brianc
Copy link
Owner

brianc commented Mar 15, 2024

Doh! Looks like node-libpq isn't compiling on node 20. Makes sense...I'll see about updating that lib as soon as I'm out of my current job & get more time to really pour some fire on this project!! For now, we'll just skip the native version in CI - really appreciate you! ❤️

@brianc brianc merged commit a717c00 into brianc:master Mar 15, 2024
7 checks passed
@alxndrsn alxndrsn deleted the ci-node-20 branch March 17, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants