Unable to reconnect after calling pg.end() #395
Conversation
Leaving a reference to the pool means the destroyed pool will get returned if you later try to reconnect with the same connection string.
|
I think that change is logical certainly. I think a simple test case would be something like connecting, disconnecting, and destroying a pool a few times with I definitely appreciate the pull request. Once you get it tested I'll merge! 😄 |
|
Will take me a couple days to get to this. Busy times. Do you have an opinion on if this fits better as a unit or integration test? Haven't looked much into it so don't have a clear sense of what's mocked for the units, etc. |
|
Integration test I think. A lot of the stuff with connect/disconnect/reconnect is vulnerable to timing bugs which unit tests don't catch. |
|
I can write the tests if you describe in a high level the scenario I can create to reproduce the bug. |
Unable to reconnect after calling pg.end()
|
Thanks for your help. Sorry for the delay - life gets crazy some times. 😄 |
|
Glad you were able to merge this. Sorry I never found the time to help with the followup (i.e., tests). |
|
Hi @brianc I can't seem to get this change by doing a npm install . I'm looking at version 2.11.1 on my machine, but it has an outdated index.js. Can you please bump the version number? Or push it to NPM? |
I discovered this while doing tests with pg. Between tests, pg.end() is called to clear out the pool, and then I call pg.connect() again, with the same connection string.
Is there a better way to dump the pool (e.g. any hung connections) and create a new pool?
I have not yet added additional tests, but did confirm that existing tests still pass.