Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard postgres:// URL prefix for consistency #407

Merged
merged 1 commit into from
Jul 23, 2013

Conversation

msakrejda
Copy link
Contributor

Fixes #286.

Passes make test-all.

@brianc
Copy link
Owner

brianc commented Jul 22, 2013

Looks good to me! 👍

I appreciate your attention to detail in things like this. Technically the library just ignores the URL prefix, but it's good to have the standard prefix in there for clarity.

@msakrejda
Copy link
Contributor Author

Thanks! And thanks for making it easy to contribute via the build instructions. The only rough spot was running the tests and npm installing all the missing packages as things blew up--is there a better way to do that? I'm a Postgres guy but have never really worked with node.

@brianc
Copy link
Owner

brianc commented Jul 23, 2013

@deafbybeheading once you clone the repo you generally have to type npm install as it's kinda bad form to "automatically" install things when typing make test. If a single npm install didn't install everything needed to run the test...that's a bug...but I'm pretty sure it does because that's how travis runs everything & it works.

brianc added a commit that referenced this pull request Jul 23, 2013
Use the standard postgres:// URL prefix for consistency
@brianc brianc merged commit 7c21815 into brianc:master Jul 23, 2013
@msakrejda
Copy link
Contributor Author

Okay, yeah, npm install is what I was missing. This is literally the first time I worked with node, so I didn't know what I was doing. Maybe add a link to node installation instructions and a note to run npm install to the contributing instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

align URL format with libpq in documentation
2 participants