Added missing argument to handleError method call. #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, it would crash with a very unhelpful error message: [project path]/node_modules/pg/lib/query.js:92 connection.sync(); ^ TypeError: Cannot call method 'sync' of undefined at Query.handleError ([project path]/node_modules/pg/lib/query.js:92:16) at Client.connect ([project path]/node_modules/pg/lib/client.js:178:24) at g (events.js:185:14) at EventEmitter.emit (events.js:85:17) at Socket.<anonymous> ([project path]/node_modules/pg/lib/connection.js:60:10) at Socket.EventEmitter.emit (events.js:85:17) at TCP.onread (net.js:424:51) After the change, it reports a much more helpful error running query [Error: Stream unexpectedly ended during query execution]
|
👍 |
brianc
added a commit
that referenced
this pull request
Apr 3, 2014
Added missing argument to handleError method call.
|
Thanks for this - very helpful! Pretty sure the way I had it before your fix was just a downright bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, it would crash with a very unhelpful error message:
After the change, it reports a much more helpful