Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up timeout for tests against AWS from 5s to 15s #577

Merged
merged 2 commits into from May 2, 2014

Conversation

rngadam
Copy link

@rngadam rngadam commented Apr 25, 2014

More often than not, connection to the AWS test server will timeout for locations with poor Internet connectivity (China..).

@brianc
Copy link
Owner

brianc commented Apr 27, 2014

You're in china? That's rad! How would you feel about instead of modifying particular tests, making the timeout an environment variable like TEST_TIMEOUT? Then assert.calls could be like:

var timeout = parseInt(process.env.TEST_TIMEOUT) || 5000;

That might help on travis as well where things run really slow as well. Then it can be configured in one place for every test. None of the tests actually test the timeliness of anything, the duration of the timeout was strictly arbitrarily set to 5000.

@rngadam
Copy link
Author

rngadam commented May 2, 2014

Modified to add global variable parsing in test-helper!

BTW, if you're interested in coming to Shanghai, ping me by email ;-).

@brianc
Copy link
Owner

brianc commented May 2, 2014

Nice! 👍

Thanks for the offer! If I do come over I will definitely take you up on it. :)

Thanks for the PR too! 👍

brianc added a commit that referenced this pull request May 2, 2014
bump up timeout for tests against AWS from 5s to 15s
@brianc brianc merged commit 740d0a6 into brianc:master May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants