Fixed passing config to subquery

brianc · Nov 16, 2015 · 8cb5280 · 8cb5280
1 parent fb67977
commit 8cb5280
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/dialect/postgres.js b/lib/dialect/postgres.js
@@ -662,7 +662,7 @@ Postgres.prototype.visitQueryHelper=function(actions,targets,filters){
 
 Postgres.prototype.visitSubquery = function(queryNode) {
   // create another query builder of the current class to build the subquery
-  var subQuery = new this._myClass();
+  var subQuery = new this._myClass(this.config);
 
   // let the subquery modify this instance's params array
   subQuery.params = this.params;

diff --git a/test/dialects/subquery-tests.js b/test/dialects/subquery-tests.js
@@ -85,6 +85,36 @@ Harness.test({
   params: []
 });
 
+// Subquery with a date
+Harness.test({
+  query: Sql.select('*').from(post.subQuery().where(post.content.equals(new Date('Sat, 01 Jan 2000 00:00:00 GMT')))),
+  pg: {
+    text  : 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = $1))',
+    string: 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = \'2000-01-01T00:00:00.000Z\'))'
+  },
+  sqlite: {
+    text  : 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = $1))',
+    string: 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = 946684800000))',
+    config: {
+        dateTimeMillis: true
+    }
+  },
+  mysql: {
+    text  : 'SELECT * FROM (SELECT * FROM `post` WHERE (`post`.`content` = ?))',
+    string: 'SELECT * FROM (SELECT * FROM `post` WHERE (`post`.`content` = \'2000-01-01T00:00:00.000Z\'))'
+  },
+  mssql: {
+    text  : 'SELECT * FROM (SELECT * FROM [post] WHERE ([post].[content] = @1))',
+    string: 'SELECT * FROM (SELECT * FROM [post] WHERE ([post].[content] = \'2000-01-01T00:00:00.000Z\'))'
+  },
+  oracle: {
+    text  : 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = :1))',
+    string: 'SELECT * FROM (SELECT * FROM "post" WHERE ("post"."content" = \'2000-01-01T00:00:00.000Z\'))'
+  },
+  params: [new Date('Sat, 01 Jan 2000 00:00:00 GMT')]
+});
+
+
 Harness.test({
   query: Sql.select('*').from(customer.subQuery('T1')).from(user.subQuery('T2')),
   pg: {