Skip to content

Commit

Permalink
LPS-83631 Give up on using copy constructor instead of deserializatio…
Browse files Browse the repository at this point in the history
…n. Some values have their type converted during deserialization, in the case of this ticket a JSONArray becomes a String.
  • Loading branch information
Preston-Crary authored and brianchandotcom committed Jul 25, 2018
1 parent e227003 commit d9f0a8f
Showing 1 changed file with 0 additions and 6 deletions.
Expand Up @@ -165,8 +165,6 @@ public DDMStructure addStructure(
structure.setStorageType(storageType);
structure.setType(type);

structure.setDDMForm(new DDMForm(ddmForm));

ddmStructurePersistence.update(structure);

// Resources
Expand Down Expand Up @@ -1590,8 +1588,6 @@ protected DDMStructureVersion addStructureVersion(
structureVersion.setStatusByUserName(user.getFullName());
structureVersion.setStatusDate(structure.getModifiedDate());

structureVersion.setDDMForm(structure.getDDMForm());

ddmStructureVersionPersistence.update(structureVersion);

return structureVersion;
Expand Down Expand Up @@ -1665,8 +1661,6 @@ protected DDMStructure doUpdateStructure(
structure.setDescriptionMap(descriptionMap, ddmForm.getDefaultLocale());
structure.setDefinition(ddmFormJSONSerializer.serialize(ddmForm));

structure.setDDMForm(new DDMForm(ddmForm));

// Structure version

DDMStructureVersion structureVersion = addStructureVersion(
Expand Down

0 comments on commit d9f0a8f

Please sign in to comment.