LPS-136032 portal-language #104689
Closed
LPS-136032 portal-language #104689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery. |
|
Closing pull request because all |
|
ci:reopen |
|
Merged. Thank you. |
|
@petershin fyi on needing 8d1897e for now but not later. |
|
thx @Preston-Crary ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shuyangzhou, this solves the conflicting default resource bundles by forcing the migrating bundle to say it still needs it's own ResourceBundle in 8d1897e. In some ways this is cleaner because we only apply the backwards compatibility where we need it. I'm not sure if we want to continue with this fix or work out the details of why different default ResourceBundles were conflicting.
@brianchandotcom once we replace all the ResourceBundleUtil usages in change-tracking-web with LanguageUtil then we won't need 8d1897e anymore.