LPS-145112 - Adds API for accessing spritemaps in both java and javascript #117185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… portal-kernal, portal-web, and util-taglib
… class it extends
…le rather than using a DynamicInclude
…igation with spa enabled
|
Closing pull request because all |
|
ci:reopen |
|
@bryceosterhaus there's a rebase error, can you resend? Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #116893
Note, in regards to your comments about having the interface and the Impl in *-api, I actually removed that module as we weren't using it and we currently don't have a need for an interface at the kernal level. Let me know if we need an empty class or some sort for that though, I am not entirely sure when we add empty placeholder classes.
I also unified the frontend feature flag approach to follow what Milton had added.
Let me know if you notice any other issues. Thanks!