forked from liferay/liferay-portal
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-37675 #12640
Closed
natecavanaugh
wants to merge
35
commits into
brianchandotcom:master
from
natecavanaugh:pull-request-1395-LPS-37675
Closed
LPS-37675 #12640
natecavanaugh
wants to merge
35
commits into
brianchandotcom:master
from
natecavanaugh:pull-request-1395-LPS-37675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d site admins link
…e 3 chars when possible, border should never be reset with none
…ect unless we have a need for those strings to be customized per instance of the widget
…e, otherwise, things don't work when there are multiples of the same id in the page
…le quotes are only needed to prevent nested quotes when passed to taglib attributes
…the panels are doing the same general work, so we shouldn't repeat all of that logic if not needed)
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.