LPS-51006 Use IG (Image Gallery) because that's the term we use in source code to refer to Documents and Media Gallery #21951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set of visible menus in media gallery is different than those of DL. Expose two factory methods in the context factory, so that DL and MG can request the appropriate display context.
Create two display contexts (DL and IG) and make both extend a new base class.
…urce code to refer to Documents and Media Gallery
|
All tests have PASSED. Refer to this link for build results (access rights to CI server needed): |
|
Merged. Thank you. |
|
@adolfopa beautifully done. breaking it down into smaller commits like that makes it very easy to review. Good job Adolfo. @sergiogonzalez thanks for catching the typo. |
|
I found one bug in Eclipse because there was a new class that had the same package and name in portal-service. I fixed it though in 8c462dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.