Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-52280 Tests #23193

Closed
wants to merge 15 commits into from
Closed

LPS-52280 Tests #23193

wants to merge 15 commits into from

Conversation

sergiogonzalez
Copy link

No description provided.

robertoDiaz and others added 15 commits January 12, 2015 15:30
@robertoDiaz
LPS-51882 Create tests BlogsEntryAttachmentFileEntryHelper
096286a
LPS-51882 Use the same method name that is being tested
8a420b1
LPS-51882 Simplify
51cdfd3
LPS-51882 Separate test concern so we have 2 tests: #1 test to make s…
eb459e8 
…ure that the data return by BlogsEntryAttachmentFileEntryReference is correct and is used properly #2 make sure that the content of the blog entry is correctly replaced
LPS-51882 Encapsulate logic
cb5067c
LPS-51882 SF
97137e4
LPS-51882 Create a content more challenging to make sure that the cod…
d03b68a 
…e is working in more complex scenarios
LPS-51882 Delete the user after running the tests
1c9a6dc
LPS-51882 SF
aca56e5
LPS-51882 Create more specific unit tests to add coverage on the upda…
181ca4d 
…teContent method with the different regexp possibilities. Make it unit test instead of integration. These tests actually detected a bug that it's necessary to be fixed that the integration tests didn't catch.
LPS-51882 Make all the auxiliary methods protected and ant format-source
21db881
@robertoDiaz
LPS-51882 Fix regexp
7a9bd6e
@robertoDiaz
LPS-52280 Delete duplicate tests (this logic is been tested in the un…
cd126f7 
…it methods)
@robertoDiaz
LPS-52280 DRY
2fc1777
LPS-52280 SF
0f75cbc
@sergiogonzalez sergiogonzalez mentioned this pull request Jan 12, 2015
Closed
@sergiogonzalez sergiogonzalez changed the title LPS-52280 SF LPS-52280 Tests Jan 12, 2015
@sergiogonzalez
Copy link
Author

Will resend because there are some wrong LPS numbers.

@sergiogonzalez
Copy link
Author

This is the right one: #23194

@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED!

Build Time: 17 minutes 57 seconds

See the following links for more information.

@sergiogonzalez sergiogonzalez deleted the pr-1880 branch April 18, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiogonzalez @liferay-continuous-integration @robertoDiaz