LPS-56372 Extend CommandAction framework to have better support for resourceURLs and renderURLs

[sergiogonzalez]

No description provided.

[liferay-continuous-integration]

Some tests FAILED!

Build Time: 28 minutes 47 seconds

See the following links for more information.

• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest(master)/156/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-start(master)/156/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/156/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-plugins(master)/131/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-backend(master)/131/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-stop(master)/156/

1 Failure.

• com.liferay.portal.util.InitUtilTest.testBaseSeleniumTestCaseSpringConfigs

  java.lang.IllegalStateException: The system has not be activated yet.
  
  java.lang.RuntimeException: java.lang.IllegalStateException: The system has not be activated yet.
  	at com.liferay.portal.util.InitUtil.stopRuntime(InitUtil.java:248)
  	at com.liferay.portal.util.InitUtilTest.testBaseSeleniumTestCaseSpringConfigs(InitUtilTest.java:70)
  	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:62)
  Caused by: java.lang.IllegalStateException: The system has not be activated yet.
  	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.setStartLevel(ModuleContainer.java:1442)
  	at com.liferay.portal.bootstrap.ModuleFrameworkImpl.stopRuntime(ModuleFrameworkImpl.java:410)
  	at com.liferay.portal.module.framework.ModuleFrameworkUtilAdapter.stopRuntime(ModuleFrameworkUtilAdapter.java:115)
  	at com.liferay.portal.util.InitUtil.stopRuntime(InitUtil.java:245)
  

[sergiogonzalez]

Hey @rotty3000 @peterfellwock @marcellustavares @brunobasto @leoadb @juliocamarero @epgarcia @mhan810

I have extend the MVCPortlet framework regarding ActionCommand.java. Before we were using ActionCommand.java for both actionURL and resourceURL. I have splitted that in 2 different interfaces. Besides that, the ResourceCommand that will be used is based on resourceID and not based on ActionRequest.ACTION_NAME parameter.
I have also created a new one for renderURL using the mvcAction parameter so the render of the RenderCommand will be invoked based on mvcAction parameter.

I have modified all the uses that I could find in your plugins, so when ActionCommand were used for resourceURLs I have updated that to use ResourceCommand classes. I have done all the changes and you guys shouldn't need to do anything, I'm just ccing you so you're aware of the changes and you can check them or ask any question you may have.

@marcellustavares I have also done a fix for DDM in sergiogonzalez@ee5711e because that URL wasn't pointing to any resource handling logic

Thanks

[sergiogonzalez]

ci:retest

[liferay-continuous-integration]

All tests PASSED!

Build Time: 41 minutes 25 seconds

See the following links for more information.

• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest(master)/158/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-start(master)/158/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/158/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-plugins(master)/133/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-backend(master)/133/
• https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-stop(master)/158/

[marcellustavares]

Thanks @sergiogonzalez, nice improvement :) Thanks for doing that

[brunobasto]

Thank you, @sergiogonzalez!!

[sergiogonzalez]

cc/ @izaera @JorgeFerrer

[rotty3000]

Good job @sergiogonzalez!

[brianchandotcom]

Hey @sergiogonzalez This is very good. Can you resend in separate pulls:

First pull:

1.) Rename "action.command.name" to "mvc.command.name" I think it's easier to comprehend at the OSGi @component level if we prefix everything wth mvc.*

2.) Rename "ActionCommand" to "MVCActionCommand" in preparation for "MVCRenderCommand" etc.

Second pull:

Add Render and Resource specific things.

Thx @sergiogonzalez