Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-28985 Manage Header with HashSet #6311

Closed
wants to merge 1 commit into from

Conversation

shuyangzhou
Copy link

No description provided.

@rotty3000
Copy link

@shuyangzhou regarding your question about

List<Header> headerValues = ListUtil.copy(entry.getValue());

It was because headers were being cleared by subsequent code, since the List is a reference, and clearing values from the list cleared them from the response.

If you tested to make sure the headers (of all types) set in a portlet (including plugins) actually arrive at the client, I'm ok with your change.

@shuyangzhou
Copy link
Author

@rotty3000

The List from entry.getValue() is only used within this for loop. After the loop all headers are putted into response object, no matter you clear the list or not, it won't affect the response object.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 5fe237f...7cbd0cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants